From 19e18096158534c79f8d0bbb4f0f1a14969ca3d4 Mon Sep 17 00:00:00 2001 From: neil Date: Fri, 2 Dec 2022 08:01:24 +0800 Subject: [PATCH 1/2] hide package reviews --- .../gui/src/routes/packages/[slug]/+page.svelte | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/gui/src/routes/packages/[slug]/+page.svelte b/packages/gui/src/routes/packages/[slug]/+page.svelte index 65bd403..9d0e6a2 100644 --- a/packages/gui/src/routes/packages/[slug]/+page.svelte +++ b/packages/gui/src/routes/packages/[slug]/+page.svelte @@ -22,11 +22,12 @@ if (!pkg && foundPackage) { pkg = foundPackage; } - if (!reviews && pkg) { - packagesReviewStore.subscribe(pkg.full_name, (updatedReviews) => { - reviews = updatedReviews; - }); - } + // TODO: uncomment when api is ready + // if (!reviews && pkg) { + // packagesReviewStore.subscribe(pkg.full_name, (updatedReviews) => { + // reviews = updatedReviews; + // }); + // } }; packages.subscribe(setPkg); @@ -38,7 +39,10 @@
+ From 191f2764810a3936bee3d896a2bbd046235f5807 Mon Sep 17 00:00:00 2001 From: neil Date: Fri, 2 Dec 2022 09:52:04 +0800 Subject: [PATCH 2/2] #49 added and use @tea/ui/ImgPreloader --- packages/gui/.prettierrc | 2 +- packages/gui/package.json | 3 +- .../FeaturedPackages/FeaturedPackage.svelte | 12 ++++--- .../FeaturedPackages/FeaturedPackages.svelte | 31 +++++++++++-------- .../GettingStarted/GettingStarted.svelte | 4 +-- .../gui/src/components/NavBar/NavBar.svelte | 6 ++-- .../PackageBanner/PackageBanner.svelte | 14 ++++----- .../PackageReviews/PackageReviews.svelte | 10 +++--- .../components/PageHeader/PageHeader.svelte | 2 +- .../components/Placeholder/Placeholder.svelte | 2 +- .../SearchPackages/SearchPackages.svelte | 19 +++++++++--- .../SearchPackages/SortingButtons.svelte | 4 +-- packages/gui/src/libs/api/mock.ts | 7 +++++ packages/gui/src/libs/stores.ts | 2 +- .../src/routes/packages/[slug]/+page.svelte | 8 ++--- packages/ui/.prettierrc | 2 +- packages/ui/package.json | 3 +- .../ui/src/ArticleCard/ArticleCard.svelte | 12 +++---- packages/ui/src/Button/Button.svelte | 2 +- .../ui/src/ImgLoader/ImgLoader.stories.ts | 28 +++++++++++++++++ packages/ui/src/ImgLoader/ImgLoader.svelte | 24 ++++++++++++++ .../ui/src/PackageCard/PackageCard.svelte | 11 ++++--- .../ui/src/Preloader/Preloader.stories.ts | 14 +++++++++ packages/ui/src/Preloader/Preloader.svelte | 9 ++++++ packages/ui/src/ReviewCard/ReviewCard.svelte | 6 ++-- .../ui/src/SearchInput/SearchInput.svelte | 2 +- pnpm-lock.yaml | 25 +++++++++++---- 27 files changed, 191 insertions(+), 73 deletions(-) create mode 100644 packages/ui/src/ImgLoader/ImgLoader.stories.ts create mode 100644 packages/ui/src/ImgLoader/ImgLoader.svelte create mode 100644 packages/ui/src/Preloader/Preloader.stories.ts create mode 100644 packages/ui/src/Preloader/Preloader.svelte diff --git a/packages/gui/.prettierrc b/packages/gui/.prettierrc index 1176c1f..ea07536 100644 --- a/packages/gui/.prettierrc +++ b/packages/gui/.prettierrc @@ -4,7 +4,7 @@ "singleQuote": true, "trailingComma": "none", "printWidth": 100, - "plugins": ["prettier-plugin-svelte"], + "plugins": ["prettier-plugin-svelte", "prettier-plugin-tailwindcss"], "pluginSearchDirs": ["."], "overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }] } diff --git a/packages/gui/package.json b/packages/gui/package.json index 77b5824..fd63afa 100644 --- a/packages/gui/package.json +++ b/packages/gui/package.json @@ -27,8 +27,9 @@ "eslint-config-prettier": "^8.3.0", "eslint-plugin-svelte3": "^4.0.0", "postcss": "^8.4.19", - "prettier": "^2.6.2", + "prettier": "^2.7.1", "prettier-plugin-svelte": "^2.7.0", + "prettier-plugin-tailwindcss": "^0.2.0", "svelte": "^3.49.0", "svelte-check": "^2.8.0", "svelte-preprocess": "^4.10.7", diff --git a/packages/gui/src/components/FeaturedPackages/FeaturedPackage.svelte b/packages/gui/src/components/FeaturedPackages/FeaturedPackage.svelte index 31025de..7f9c3ff 100644 --- a/packages/gui/src/components/FeaturedPackages/FeaturedPackage.svelte +++ b/packages/gui/src/components/FeaturedPackages/FeaturedPackage.svelte @@ -1,29 +1,33 @@ -
- + +

{pkg.name}

{#if pkg.maintainer} -

• {pkg.maintainer}

+

• {pkg.maintainer}

{/if}