From 4e4fa273649acac8ef2f64996e5f8cac5463101c Mon Sep 17 00:00:00 2001 From: neil Date: Wed, 21 Dec 2022 13:08:55 +0800 Subject: [PATCH 1/2] #101 news and essential workshops should open browser --- .../components/EssentialWorkshops/EssentialWorkshops.svelte | 2 +- .../src/components/FeaturedCourses/FeaturedCourses.svelte | 1 + modules/gui/src/components/News/News.svelte | 2 +- modules/ui/src/Gallery/Gallery.svelte | 3 ++- modules/ui/src/Posts/Posts.svelte | 5 ++++- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/modules/gui/src/components/EssentialWorkshops/EssentialWorkshops.svelte b/modules/gui/src/components/EssentialWorkshops/EssentialWorkshops.svelte index 4d48bd8..d559d35 100644 --- a/modules/gui/src/components/EssentialWorkshops/EssentialWorkshops.svelte +++ b/modules/gui/src/components/EssentialWorkshops/EssentialWorkshops.svelte @@ -16,7 +16,7 @@ {#if courses.length} - + {:else}
diff --git a/modules/gui/src/components/FeaturedCourses/FeaturedCourses.svelte b/modules/gui/src/components/FeaturedCourses/FeaturedCourses.svelte index 4febfe4..7e76fe8 100644 --- a/modules/gui/src/components/FeaturedCourses/FeaturedCourses.svelte +++ b/modules/gui/src/components/FeaturedCourses/FeaturedCourses.svelte @@ -23,4 +23,5 @@ imageUrl: course.banner_image_url, link: course.link }))} + linkTarget="_blank" /> diff --git a/modules/gui/src/components/News/News.svelte b/modules/gui/src/components/News/News.svelte index 91069ab..800aa9f 100644 --- a/modules/gui/src/components/News/News.svelte +++ b/modules/gui/src/components/News/News.svelte @@ -16,7 +16,7 @@ {#if news.length} - + {:else}
diff --git a/modules/ui/src/Gallery/Gallery.svelte b/modules/ui/src/Gallery/Gallery.svelte index 1c1d5ef..5aec659 100644 --- a/modules/ui/src/Gallery/Gallery.svelte +++ b/modules/ui/src/Gallery/Gallery.svelte @@ -6,6 +6,7 @@ import GalleryItem from './GalleryItem.svelte'; export let title = ''; + export let linkTarget = ''; interface GalleryItemShape { imageUrl: string; @@ -77,7 +78,7 @@
{#each items as item}
- +
diff --git a/modules/ui/src/Posts/Posts.svelte b/modules/ui/src/Posts/Posts.svelte index 62c1d3a..f3bbde4 100644 --- a/modules/ui/src/Posts/Posts.svelte +++ b/modules/ui/src/Posts/Posts.svelte @@ -2,6 +2,7 @@ import '../app.css'; import type { AirtablePost } from '../types'; + export let linkTarget = ''; export let posts: AirtablePost[] = []; @@ -15,7 +16,9 @@

{article.title}

{article.short_description}

- Read more ... + Read more ...
From a8f1b3ff4cd36ed5328a3866b9160bb373f7348c Mon Sep 17 00:00:00 2001 From: neil Date: Wed, 21 Dec 2022 13:14:57 +0800 Subject: [PATCH 2/2] #101 footer links to open browser --- .../components/FooterLinks/FooterLinks.svelte | 62 ++++++++++++++----- .../gui/src/components/NavBar/NavBar.svelte | 11 ++-- 2 files changed, 53 insertions(+), 20 deletions(-) diff --git a/modules/gui/src/components/FooterLinks/FooterLinks.svelte b/modules/gui/src/components/FooterLinks/FooterLinks.svelte index 9bc56ef..50e294c 100644 --- a/modules/gui/src/components/FooterLinks/FooterLinks.svelte +++ b/modules/gui/src/components/FooterLinks/FooterLinks.svelte @@ -12,35 +12,55 @@ here.

- + grid